GutoVeronezi commented on PR #849: URL: https://github.com/apache/commons-lang/pull/849#issuecomment-1176222681
Hi, @kinow, thanks for the reply. @garydgregory, it feels a bit weird for us here on the other side proposing things to contribute back to commons-lang and interacting with reviewers to see somebody "taking over the changes". If the PR is missing something or there is a better way to do something, I would expect the reviewers to point what can be improved, or at least it being merged with some changes/rebase and so on (as described by @kinow https://github.com/apache/commons-lang/pull/849#issuecomment-1175649542). This way of applying the changes (closing the PR and pushing it as yours, without co-authoring) discourages new contributors, because we do not receive the credit for all the work we did (neither in Git history nor in GitHub Insights). Anyways, thanks for accepting my changes, I will now work on our side to use the new release of commons-lang as soon as it is released. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
