Claudenw commented on code in PR #329:
URL:
https://github.com/apache/commons-collections/pull/329#discussion_r946467502
##########
src/main/java/org/apache/commons/collections4/bloomfilter/BloomFilter.java:
##########
@@ -69,7 +73,7 @@ public interface BloomFilter extends IndexProducer,
BitMapProducer {
*/
default boolean contains(BloomFilter other) {
Objects.requireNonNull(other, "other");
- return isSparse() ? contains((IndexProducer) other) :
contains((BitMapProducer) other);
+ return (characteristics()&SPARSE)>0 ? contains((IndexProducer) other)
: contains((BitMapProducer) other);
Review Comment:
fixed
##########
src/main/java/org/apache/commons/collections4/bloomfilter/SimpleBloomFilter.java:
##########
@@ -65,7 +65,7 @@ public SimpleBloomFilter(BloomFilter other) {
this.shape = other.getShape();
this.bitMap = new
long[BitMap.numberOfBitMaps(shape.getNumberOfBits())];
this.cardinality = 0;
- if (other.isSparse()) {
+ if ((other.characteristics()&SPARSE)>0) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
