[GitHub] [commons-lang] tisonkun commented on pull request #951: [LANG-1692] Cast FieldUtils.readField result to the recipient type

[GitBox]

tisonkun commented on PR #951:
URL: https://github.com/apache/commons-lang/pull/951#issuecomment-1249958768

   I may write something like:
   
   ```diff
   diff --git 
a/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java 
b/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java
   index b68a994f3..dcecbca06 100644
   --- a/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java
   +++ b/src/test/java/org/apache/commons/lang3/reflect/FieldUtilsTest.java
   @@ -480,7 +480,8 @@ public void 
testReadDeclaredNamedStaticFieldForceAccess() throws Exception {
        @Test
        public void testReadField() throws Exception {
            final Field parentS = FieldUtils.getDeclaredField(parentClass, "s");
   -        assertEquals("s", FieldUtils.readField(parentS, publicChild));
   +        String s = FieldUtils.readField(parentS, publicChild);
   +        assertEquals("s", s);
            assertEquals("s", FieldUtils.readField(parentS, 
publiclyShadowedChild));
            assertEquals("s", FieldUtils.readField(parentS, 
privatelyShadowedChild));
            final Field parentB = FieldUtils.getDeclaredField(parentClass, "b", 
true);
   ```
   
   to prove this change works. But it seems useless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org