aherbert commented on code in PR #38:
URL: https://github.com/apache/commons-statistics/pull/38#discussion_r979316838


##########
commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BaseDiscreteDistributionTest.java:
##########
@@ -65,7 +65,7 @@
  * The parameters are parsed from String values to the appropriate parameter 
object. Currently
  * this supports Double and Integer; numbers can be unboxed and used to create 
the distribution.
  *
- * <p>Illegal arguments for the distribution are tested from 
parametersprovided by
+ * <p>Illegal arguments for the distribution are tested from 
parameters-provided by

Review Comment:
   No hyphen required here



##########
commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TruncatedNormalDistributionTest.java:
##########
@@ -200,7 +200,7 @@ void testVariance() {
     /**
      * Test cases for computation of the moments. This hits edge cases 
including truncations
      * too extreme to have a probability range for the distribution.
-     * The test ensures that the moments are computable for parameterisations
+     * The test ensures that the moments are computable for parameters-provided

Review Comment:
   Parameterisations is the intended term. It is a British alternative spelling 
of [parametrization](https://en.wiktionary.org/wiki/parametrization). It is 
intended to describe the result of parameters, i.e. 'computable for the result 
of parameters (the distribution under test) where the bounds fall within'. Feel 
free to update it to the US english which is more standard for commons 
components.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to