[GitHub] [commons-lang] tisonkun commented on a diff in pull request #951: [LANG-1692] Cast FieldUtils.readField result to the recipient type

[GitBox]

tisonkun commented on code in PR #951:
URL: https://github.com/apache/commons-lang/pull/951#discussion_r990638932


##########
src/main/java/org/apache/commons/lang3/builder/ReflectionDiffBuilder.java:
##########
@@ -110,8 +110,9 @@ private void appendFields(final Class<?> clazz) {
         for (final Field field : FieldUtils.getAllFields(clazz)) {
             if (accept(field)) {
                 try {
-                    diffBuilder.append(field.getName(), readField(field, left, 
true),
-                            readField(field, right, true));
+                    Object leftObject = readField(field, left, true);

Review Comment:
   If you think it breaks the existing code and should not do it, you can 
reject the PR. But I'm a bit confused since reverting it obviously causes 
compile to fail.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org