garydgregory commented on code in PR #26:
URL: https://github.com/apache/commons-jxpath/pull/26#discussion_r999316059


##########
src/main/java/org/apache/commons/jxpath/Functions.java:
##########
@@ -43,4 +45,15 @@ public interface Functions {
      * @return Function
      */
     Function getFunction(String namespace, String name, Object[] parameters);
+
+    /**
+     * Returns a Function, if any, for the specified namespace,
+     * name and parameter types.
+     * @param namespace ns
+     * @param name function name
+     * @param parameters Object[]
+     * @param jxPathFilter  the XPath filter
+     * @return Function
+     */
+    Function getFunction(String namespace, String name, Object[] parameters, 
JXPathFilter jxPathFilter);

Review Comment:
   This needs to be a default method to avoid breaking binary compatibility. 
This is a misconfiguration in our parent POM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to