aherbert commented on PR #353:
URL:
https://github.com/apache/commons-collections/pull/353#issuecomment-1294562168
Note that there already is a `DualLinkedHashBidiMap` object. So this change
is converting the `DualHashBidiMap` to a `DualLinkedHashBidiMap`. This is not
the solution.
-1
As with previous PRs related to a similar issue, we should change the test
rather than the implementation. See #341, #336.
If the iteration order of the DualHashBidiMap is not specified, then do not
change it to pass an arbitrary test. To determine how flaky this test is you
could try using the `nondex` plugin. See the other linked PRs for examples.
A simple fix can be to change `testBidiKeySetValuesOrder` to check the
`getIterationBehaviour()` flag and skip this test:
```Java
@Test
public void testBidiKeySetValuesOrder() {
Assume.assumeTrue((getIterationBehaviour() &
AbstractCollectionTest.UNORDERED) == 0);
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
