kinow commented on code in PR #357:
URL:
https://github.com/apache/commons-collections/pull/357#discussion_r1014811662
##########
src/main/java/org/apache/commons/collections4/bloomfilter/HasherCollection.java:
##########
@@ -66,6 +66,16 @@ public HasherCollection(Hasher... hashers) {
this(Arrays.asList(hashers));
}
+ @Override
+ public boolean isEmpty() {
+ for (Hasher h : hashers) {
+ if (!h.isEmpty()) {
+ return false;
+ }
+ }
+ return true;
Review Comment:
Out of the loop, so can't comment on the addition of that method, but the
rest of the code looks Ok :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
