garydgregory commented on code in PR #344:
URL: https://github.com/apache/commons-compress/pull/344#discussion_r1057679052
##########
src/test/java/org/apache/commons/compress/harmony/pack200/tests/ArchiveTest.java:
##########
@@ -111,7 +121,8 @@ public void testAlternativeConstructor() throws
IOException, URISyntaxException,
out.close();
}
- public void testAnnotations() throws IOException, Pack200Exception,
+ @Test
+ void testAnnotations() throws IOException, Pack200Exception,
Review Comment:
See above.
##########
src/test/java/org/apache/commons/compress/harmony/pack200/tests/ArchiveTest.java:
##########
@@ -95,11 +104,12 @@ private void compareJarEntries(final JarFile jarFile,
final JarFile jarFile2) {
String name = entry.getName();
JarEntry entry2 = jarFile2.getJarEntry(name);
- assertNotNull("Missing Entry: " + name, entry2);
+ assertNotNull(entry2, "Missing Entry: " + name);
}
}
- public void testAlternativeConstructor() throws IOException,
URISyntaxException, Pack200Exception {
+ @Test
+ void testAlternativeConstructor() throws IOException, URISyntaxException,
Pack200Exception {
Review Comment:
See above.
##########
src/test/java/org/apache/commons/compress/harmony/pack200/tests/ArchiveTest.java:
##########
@@ -140,7 +151,8 @@ public void testAnnotations() throws IOException,
Pack200Exception,
compareFiles(jarFile, jarFile2);
}
- public void testAnnotations2() throws IOException, Pack200Exception,
+ @Test
+ void testAnnotations2() throws IOException, Pack200Exception,
Review Comment:
And so on, so I'll stop here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
