kinow commented on code in PR #295:
URL: https://github.com/apache/commons-csv/pull/295#discussion_r1083307259
##########
src/main/java/org/apache/commons/csv/CSVFormat.java:
##########
@@ -846,6 +881,8 @@ public CSVFormat getFormat() {
public static final CSVFormat EXCEL = DEFAULT.builder()
Review Comment:
>Maybe, but all spreadsheets are "lenient".
Good point. I think @garydgregory suggested the EXCEL_LENIENT format to
avoid changing the behavior for users of the EXCEL format. But if we are
changing the format to what's supported in Excel, I guess that should be fine.
##########
src/main/java/org/apache/commons/csv/CSVFormat.java:
##########
@@ -846,6 +881,8 @@ public CSVFormat getFormat() {
public static final CSVFormat EXCEL = DEFAULT.builder()
Review Comment:
>Maybe, but all spreadsheets are "lenient".
Good point. I think @garydgregory suggested the EXCEL_LENIENT format to
avoid changing the behavior for users of the EXCEL format. But if we are
changing the format to the way it works in Excel, I guess that should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
