DamjanJovanovic opened a new pull request, #303:
URL: https://github.com/apache/commons-csv/pull/303

   Continued from PR 295.
   
   The test was failing because the test was wrong, not because my patches were 
wrong.
   
   The test should match Excel's interpretation of the CSV file. Excel fuses 
lines 3 and 4 together, because the last field on line 3 doesn't end in a 
quote, so it continues into the next line. There, it stops at the initial 
quote, unquoting that portion, then also adds everything up to the comma, and 
all this becomes field 2 of line 3. The remaining fields on line 4 are 
interpreted as successive line 3 fields, and because the last field doesn't 
have a terminating quote, and the file ends in a new line, the last field also 
ends in a new line.
   
   Once these corrections are made, the test passes.
   
   Also add a RAT exclude for the sample file, which was missed out in commit 
1269c133ff4637ed658fb8ab5d78a8671ecfed4a, and breaks the build.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to