garydgregory commented on code in PR #270:
URL:
https://github.com/apache/commons-configuration/pull/270#discussion_r1092049982
##########
pom.xml:
##########
@@ -551,15 +551,15 @@
org.apache.commons.vfs2.*;resolution:=optional,
org.springframework.*;resolution:=optional,
com.fasterxml.jackson.*;resolution:=optional,
- org.yaml.snakeyaml.*;resolution:=optional,
+ org.snakeyaml.engine.*;resolution:=optional,
*
</commons.osgi.import>
<log4j.version>2.19.0</log4j.version>
<slf4j.version>2.0.5</slf4j.version>
<!-- Spring 6 requires Java 17 -->
<spring.version>5.3.24</spring.version>
- <japicmp.skip>false</japicmp.skip>
+ <japicmp.skip>true</japicmp.skip>
Review Comment:
Yes: Don't change that setting. You cannot break binary compatibility (BC)
outside of a major release upgrade. If PR breaks BC, then it's -1.
Gary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
