sebbASF commented on code in PR #125:
URL: https://github.com/apache/commons-net/pull/125#discussion_r1093318537
##########
src/main/java/org/apache/commons/net/ftp/FTPInputStream.java:
##########
@@ -0,0 +1,20 @@
+package org.apache.commons.net.ftp;
Review Comment:
Needs AL header
##########
src/main/java/org/apache/commons/net/ftp/FTPInputStream.java:
##########
@@ -0,0 +1,20 @@
+package org.apache.commons.net.ftp;
+
+import java.io.FilterInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+
+public class FTPInputStream extends FilterInputStream {
Review Comment:
Needs Javadoc.
Also the class name is very generic, and does not hint at its functionality
##########
src/main/java/org/apache/commons/net/ftp/FTPOutputStream.java:
##########
@@ -0,0 +1,21 @@
+package org.apache.commons.net.ftp;
+
+import java.io.FilterOutputStream;
+import java.io.IOException;
+import java.io.OutputStream;
+
+public class FTPOutputStream extends FilterOutputStream {
Review Comment:
Needs Javadoc.
Also class name does not relate to its function
##########
src/test/java/org/apache/commons/net/ftp/FTPSClientTest.java:
##########
@@ -66,6 +69,16 @@ public FTPSClientTest(final boolean endpointCheckingEnabled)
{
super(endpointCheckingEnabled, null, null);
}
+ @Test
+ public void testStore() throws IOException {
+ FTPSClient ftpsClient = loginClient();
+ try(InputStream localSource =
FTPSClientTest.class.getResourceAsStream("sample.txt");
+ OutputStream remoteDestination =
ftpsClient.storeFileStream("sample.txt")) {
+ IOUtils.copy(localSource, remoteDestination);
+ }
+ ftpsClient.disconnect();
+ }
+
Review Comment:
Need some more tests to exercise more of the code.
##########
src/main/java/org/apache/commons/net/ftp/FTPOutputStream.java:
##########
@@ -0,0 +1,21 @@
+package org.apache.commons.net.ftp;
Review Comment:
Need AL header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
