[ 
https://issues.apache.org/jira/browse/GEOMETRY-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709694#comment-17709694
 ] 

Andreas Goss commented on GEOMETRY-144:
---------------------------------------

While adjusting the code for the 2D case, I ran into some unexpected problems.  
Deleting the interface and returning {{LinePath}} will introduce some 
imprecisions into the vertex list ( {{ConvexHull}} returns an exact vertex list 
whereas {{LinePath}} relying on {{Segment}} does not necessarily). Since there 
are already a lot of tests and a lot of consideration went into testing the 2D 
case, it is maybe best (like initially suggested by Matt) to keep the 
{{ConvexHull}} interface and to have direct control over the returned vertex 
list. Sorry for taking so long. I have also been on vacation for the last few 
weeks.

> Review API in "hull" module
> ---------------------------
>
>                 Key: GEOMETRY-144
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-144
>             Project: Commons Geometry
>          Issue Type: Task
>            Reporter: Gilles Sadowski
>            Assignee: Gilles Sadowski
>            Priority: Minor
>             Fix For: 1.1
>
>
> Review codes in the 
> [{{commons-geometry-hull}}|https://gitbox.apache.org/repos/asf?p=commons-geometry.git;a=tree;f=commons-geometry-hull;hb=HEAD]
>  module.
> (x) Minimize the public API



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to