garydgregory commented on code in PR #394:
URL: https://github.com/apache/commons-compress/pull/394#discussion_r1232628379
##########
src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/forms/InitMethodReferenceForm.java:
##########
@@ -49,7 +49,7 @@ protected int getPoolID() {
protected void setNestedEntries(final ByteCode byteCode, final
OperandManager operandManager, final int offset)
throws Pack200Exception {
final SegmentConstantPool globalPool =
operandManager.globalConstantPool();
- ClassFileEntry[] nested = null;
+ ClassFileEntry[] nested;
Review Comment:
@mawiesne How about here?
##########
src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/forms/NewInitMethodRefForm.java:
##########
@@ -41,7 +41,7 @@ protected String context(final OperandManager operandManager)
{
protected void setNestedEntries(final ByteCode byteCode, final
OperandManager operandManager, final int offset)
throws Pack200Exception {
final SegmentConstantPool globalPool =
operandManager.globalConstantPool();
- ClassFileEntry[] nested = null;
+ ClassFileEntry[] nested;
Review Comment:
@mawiesne How about here?
##########
src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/forms/ReferenceForm.java:
##########
@@ -60,7 +60,7 @@ public void setByteCodeOperands(final ByteCode byteCode,
final OperandManager op
protected void setNestedEntries(final ByteCode byteCode, final
OperandManager operandManager, final int offset)
throws Pack200Exception {
final SegmentConstantPool globalPool =
operandManager.globalConstantPool();
- ClassFileEntry[] nested = null;
+ ClassFileEntry[] nested;
Review Comment:
@mawiesne How about here?
##########
src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/forms/StringRefForm.java:
##########
@@ -52,8 +51,8 @@ protected int getPoolID() {
protected void setNestedEntries(final ByteCode byteCode, final
OperandManager operandManager, final int offset)
throws Pack200Exception {
final SegmentConstantPool globalPool =
operandManager.globalConstantPool();
- ClassFileEntry[] nested = null;
- nested = new ClassFileEntry[] {((CPString)
globalPool.getValue(getPoolID(), offset))};
+ ClassFileEntry[] nested;
Review Comment:
@mawiesne How about here?
##########
src/main/java/org/apache/commons/compress/harmony/unpack200/bytecode/forms/ClassSpecificReferenceForm.java:
##########
@@ -45,7 +45,7 @@ public ClassSpecificReferenceForm(final int opcode, final
String name, final int
protected void setNestedEntries(final ByteCode byteCode, final
OperandManager operandManager, final int offset)
throws Pack200Exception {
final SegmentConstantPool globalPool =
operandManager.globalConstantPool();
- ClassFileEntry[] nested = null;
+ ClassFileEntry[] nested;
Review Comment:
@mawiesne How about here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
