orionlibs commented on PR #130: URL: https://github.com/apache/commons-numbers/pull/130#issuecomment-1634539995
> I was stating that this entire PR should be dropped and replaced with some better documentation in the Primes class header to indicate that the functionality to detect relatively prime numbers can be found in ArithmeticUtils. @aherbert not every dev knows that checking for coprimes requires a GCD calculation, but they do know what coprimes require a primes utility. So, they will use the Primes class to see what kinds of methods it has. It will not occur to them to go to the ArithmeticUtils to check specifically the GCD method JavaDoc. I can add your suggested JavaDoc to the GCD methods, of course, but............. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
