garydgregory commented on code in PR #230:
URL: https://github.com/apache/commons-pool/pull/230#discussion_r1265218231
##########
src/main/java/org/apache/commons/pool2/PooledObject.java:
##########
@@ -33,6 +34,8 @@
*/
public interface PooledObject<T> extends Comparable<PooledObject<T>> {
+ ReentrantLock lock = new ReentrantLock();
Review Comment:
Hello @zenghu1chen
A mutable global variable in an interface is an anti-pattern IMO, you've not
addressed this issue in your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
