[ https://issues.apache.org/jira/browse/CRYPTO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784770#comment-17784770 ]
Gilles Sadowski commented on CRYPTO-176: ---------------------------------------- IMHO, there is no such thing as "unnecessary dependencies" (aka "do not reinvent the wheel"). Code duplication should occur only if a dependency is forbidden for a specific reason, not just to avoid it per se. If that were a good reason, no software would have them. Having "large quantities of duplicated code" is often the result of "Oh, let's not add a dependency for just a few lines". We already had those discussions. My focus was/is on sharing and maintainability being primary virtues; "no dependency" is only a virtue if it serves a purpose other than itself. Of course, there will be code duplication across different projects, but across components of the same project, we should avoid it by default. > Drop dependency on Commons IO? > ------------------------------ > > Key: CRYPTO-176 > URL: https://issues.apache.org/jira/browse/CRYPTO-176 > Project: Commons Crypto > Issue Type: Improvement > Reporter: Sebb > Priority: Minor > > Commons IO is currently a dependency, but the only reference is to a single > method: > IOUtils.contentEquals > Consider whether to replace the dependency with local code. -- This message was sent by Atlassian Jira (v8.20.10#820010)