cpreisler commented on code in PR #437:
URL: https://github.com/apache/commons-compress/pull/437#discussion_r1390313217
##########
src/test/java/org/apache/commons/compress/compressors/lz4/FramedLZ4CompressorRoundtripTest.java:
##########
@@ -104,15 +104,17 @@ private void roundTripTest(final String testFile, final
FramedLZ4CompressorOutpu
@Test
public void test64KMultipleBlocks() throws IOException {
- final ByteArrayOutputStream buffer = new ByteArrayOutputStream();
- final byte[] expected = new byte[98304];
+ ByteArrayOutputStream buffer = new ByteArrayOutputStream();
+ byte[] expected = new byte[98304];
new Random(0).nextBytes(expected);
- try (FramedLZ4CompressorOutputStream compressor = new
FramedLZ4CompressorOutputStream(buffer,
- new
FramedLZ4CompressorOutputStream.Parameters(FramedLZ4CompressorOutputStream.BlockSize.K64,
true, false, false))) {
+ try (FramedLZ4CompressorOutputStream compressor =
+ new FramedLZ4CompressorOutputStream(buffer,
+ new
FramedLZ4CompressorOutputStream.Parameters(FramedLZ4CompressorOutputStream.BlockSize.K64,
true, false, false))) {
compressor.write(expected);
}
try (FramedLZ4CompressorInputStream sis = new
FramedLZ4CompressorInputStream(new ByteArrayInputStream(buffer.toByteArray())))
{
- assertArrayEquals(expected, IOUtils.toByteArray(sis));
+ final byte[] actual = IOUtils.toByteArray(sis);
+ assertArrayEquals(expected, actual);
Review Comment:
This is gone. From my perspective this is good to go. Please let me know if
you want any additional changes. I'm available tonight and tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
