TestBoost opened a new pull request, #262:
URL: https://github.com/apache/commons-codec/pull/262
For the test methods in the test class MessageDigestAlgorithmsTest, not all
test methods modify the contents of shared fields. We can just initialize
`digestUtilsTest` once before all the test methods to speed up this test.
However, the parameterized tests for test method
`testNonBlockingDigestRandomAccessFile` always change the the file-pointer
offset of the `RandomAccessFile` field in `digestUtilsTest` class.
There are two ways to fix this problem: one is to reinitialize
`digestUtilsTest` before the test method
`testNonBlockingDigestRandomAccessFile` like we propose in this pull request;
another is to add `randomAccessFile.seek(0);`
at the end of test method `testNonBlockingDigestRandomAccessFile`.
The test runtime can jump from `5.509 s` to `5.046 s` after applying the
changes when run on our machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
