markt-asf commented on PR #170: URL: https://github.com/apache/commons-daemon/pull/170#issuecomment-2111947729
The changes to handler are unnecessary. It is valid (as per man sigaction on a system where the compilation currently fails) to use `sa_handler` when the handling function takes the signal number as its only argument. Also, switching to `sa_sigaction` requires the addition of the `SA_SIGINFO` flag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
