kbarlowgw commented on PR #425: URL: https://github.com/apache/commons-configuration/pull/425#issuecomment-2138015261
Yes, I think this works alright for me. Thanks. Keith On Mon, May 27, 2024 at 5:25 AM Andrea Bollini ***@***.***> wrote: > hi @kbarlowgw > <https://github.com/kbarlowgw> > , > thanks for your feedback. If I understood correctly I should have added a > test related to the wrong behavior introduced dealing with unset property > e0edce6 > <https://github.com/apache/commons-configuration/commit/e0edce6f3676081d8efe3c2adf446025452bcf74> > > Indeed, running the test without further change I got the following > exception similar to your > > [ERROR] Errors: > [ERROR] TestConfigurationPropertySource.testListValueInjection » UnsatisfiedDependency Error creating bean with name 'org.apache.commons.configuration2.spring.TestConfigurationPropertySource': Unsatisfied dependency expressed through field 'booleanNullValue'; nested exception is org.springframework.beans.TypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'boolean'; nested exception is java.lang.IllegalArgumentException: Invalid boolean value [] > [ERROR] TestConfigurationPropertySource.testNullValueInjection » UnsatisfiedDependency Error creating bean with name 'org.apache.commons.configuration2.spring.TestConfigurationPropertySource': Unsatisfied dependency expressed through field 'booleanNullValue'; nested exception is org.springframework.beans.TypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'boolean'; nested exception is java.lang.IllegalArgumentException: Invalid boolean value [] > [ERROR] TestConfigurationPropertySource.testSystemPropertyValueInjection » UnsatisfiedDependency Error creating bean with name 'org.apache.commons.configuration2.spring.TestConfigurationPropertySource': Unsatisfied dependency expressed through field 'booleanNullValue'; nested exception is org.springframework.beans.TypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'boolean'; nested exception is java.lang.IllegalArgumentException: Invalid boolean value [] > [ERROR] TestConfigurationPropertySource.testValueInjection » UnsatisfiedDependency Error creating bean with name 'org.apache.commons.configuration2.spring.TestConfigurationPropertySource': Unsatisfied dependency expressed through field 'booleanNullValue'; nested exception is org.springframework.beans.TypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'boolean'; nested exception is java.lang.IllegalArgumentException: Invalid boolean value [] > [INFO] > [ERROR] Tests run: 2942, Failures: 0, Errors: 4, Skipped: 2 > > that are solved with the commit ab388c3 > <https://github.com/apache/commons-configuration/commit/ab388c3a0c97cd249dfc2945b149da8b34e01da6> > > I would appreciate a new check on your side. Thanks! > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-configuration/pull/425#issuecomment-2133052890>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BBG2EVEMPE6U3HNK6SFQDXLZEL3XNAVCNFSM6AAAAABID3UVXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTGA2TEOBZGA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
