[ 
https://issues.apache.org/jira/browse/NET-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

PJ Fanning updated NET-731:
---------------------------
    Description: 
The new openDataSecureConnection method in FTPSClient does not support 
fileTransferMode (eg DEFLATE).

[https://github.com/apache/commons-net/pull/90/files#diff-b4292a5bd3e39f502d24bce1eb934384a951a120080c870cdc68c0585a78c6e9[]
 
|https://github.com/apache/commons-net/pull/90/files#diff-b4292a5bd3e39f502d24bce1eb934384a951a120080c870cdc68c0585a78c6e9]

 

The FTPSClient code used to delegate to FTPClient `_openDataConnection_`.

[https://github.com/apache/commons-net/blob/b5038eff135dff54e2ee2d09b94ec7d8937cb09b/src/main/java/org/apache/commons/net/ftp/FTPClient.java#L696]

This method supports `wrapOnDeflate` while openDataSecureConnection does not.

I'm not sure if FTPS supports DEFLATE transfer mode but while implementing an 
Apache Pekko workaround for the NET-718, I spotted the diff.

 

  was:
The new openDataSecureConnection method in FTPSClient does not support 
fileTransferMode (eg DEFLATE).

https://github.com/apache/commons-net/pull/90/files#diff-b4292a5bd3e39f502d24bce1eb934384a951a120080c870cdc68c0585a78c6e9[
 
|https://github.com/apache/commons-net/pull/90/files#diff-b4292a5bd3e39f502d24bce1eb934384a951a120080c870cdc68c0585a78c6e9]

 

The FTPSClient code used to delegate to FTPClient _openDataConnection_

[https://github.com/apache/commons-net/blob/b5038eff135dff54e2ee2d09b94ec7d8937cb09b/src/main/java/org/apache/commons/net/ftp/FTPClient.java#L696]

This method supports `wrapOnDeflate` while openDataSecureConnection does not.

I'm not sure if FTPS supports DEFLATE transfer mode but while implementing an 
Apache Pekko workaround for the NET-718, I spotted the diff.

 


> FTPSClient no longer supports fileTransferMode (eg DEFLATE)
> -----------------------------------------------------------
>
>                 Key: NET-731
>                 URL: https://issues.apache.org/jira/browse/NET-731
>             Project: Commons Net
>          Issue Type: Task
>          Components: FTP
>            Reporter: PJ Fanning
>            Priority: Major
>
> The new openDataSecureConnection method in FTPSClient does not support 
> fileTransferMode (eg DEFLATE).
> [https://github.com/apache/commons-net/pull/90/files#diff-b4292a5bd3e39f502d24bce1eb934384a951a120080c870cdc68c0585a78c6e9[]
>  
> |https://github.com/apache/commons-net/pull/90/files#diff-b4292a5bd3e39f502d24bce1eb934384a951a120080c870cdc68c0585a78c6e9]
>  
> The FTPSClient code used to delegate to FTPClient `_openDataConnection_`.
> [https://github.com/apache/commons-net/blob/b5038eff135dff54e2ee2d09b94ec7d8937cb09b/src/main/java/org/apache/commons/net/ftp/FTPClient.java#L696]
> This method supports `wrapOnDeflate` while openDataSecureConnection does not.
> I'm not sure if FTPS supports DEFLATE transfer mode but while implementing an 
> Apache Pekko workaround for the NET-718, I spotted the diff.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to