Claudenw commented on PR #501: URL: https://github.com/apache/commons-collections/pull/501#issuecomment-2160361892
I think this block is wrong: https://github.com/apache/commons-collections/blob/bb2fac47dc24033bae8a180bc59cb1e6e8769318/src/main/java/org/apache/commons/collections4/bloomfilter/EnhancedDoubleHasher.java#L172-L207 In the upper part we reset the tetrahedral number counter so the hashing algo is reset. I don't recall why the algo is split into k<=bits and k>bits, the wrapping algorithm should work for either case (I think). What am I missing? Can this be simplified by dropping lines 172-192 inclusive? I will make the adjustment that @aherbert suggested after we resolve this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
