sigee commented on code in PR #517:
URL:
https://github.com/apache/commons-collections/pull/517#discussion_r1685777351
##########
src/test/java/org/apache/commons/collections4/ListUtilsTest.java:
##########
@@ -81,16 +81,25 @@ public void testEmptyIfNull() {
public void testEquals() {
final Collection<String> data = Arrays.asList("a", "b", "c");
- final List<String> a = new ArrayList<>( data );
- final List<String> b = new ArrayList<>( data );
-
- assertEquals(a, b);
- assertTrue(ListUtils.isEqualList(a, b));
- a.clear();
- assertFalse(ListUtils.isEqualList(a, b));
- assertFalse(ListUtils.isEqualList(a, null));
- assertFalse(ListUtils.isEqualList(null, b));
+ final List<String> list1 = new ArrayList<>( data );
Review Comment:
I renamed them because they overlapped the String constants from lines 46,
47. And they were confusing.
```
private static final String a = "a";
private static final String b = "b";
```
```
final List<String> a = new ArrayList<>( data );
final List<String> b = new ArrayList<>( data );
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
