MSaifAsif commented on code in PR #1279:
URL: https://github.com/apache/commons-lang/pull/1279#discussion_r1777529490


##########
src/test/java/org/apache/commons/lang3/StringUtilsContainsTest.java:
##########
@@ -37,54 +34,22 @@ public class StringUtilsContainsTest extends 
AbstractLangTest {
     public void testContains_Char() {
         assertFalse(StringUtils.contains(null, ' '));
         assertFalse(StringUtils.contains("", ' '));
-        assertFalse(StringUtils.contains("", null));

Review Comment:
   I migrated it over 
[here](https://github.com/apache/commons-lang/pull/1279/files#diff-26c06c4f25342a7e49477cabfc7198f12a7d76023e2a7f3987d2341619669eb6R33).
 Would you prefer that we keep the existing StringUtils test cases as well on 
top of the separation that I did ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to