[
https://issues.apache.org/jira/browse/MATH-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17886375#comment-17886375
]
Gilles Sadowski commented on MATH-1650:
---------------------------------------
Pasting below a comment posted last week on GitHub.
{quote}
- Unclarity about if extending `SplineInterpolator` by simply overloading
`interpolate()` function is the correct design approach here, or, if it should
be realised differently. I was expecting a clearer feedback from the
maintainers.
- Tests are missing.
{quote}
I don't recall the details (from almost two years ago) but, rereading my [last
comment|https://issues.apache.org/jira/browse/MATH-1650?focusedCommentId=17628356&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17628356],
it seemed that "no tests" were a "no-go" because the API blew up on the first
try, also implying that _overloading_ {{interpolate}} was leading to an
inconsistent API.
Reminder: current version (4.0) is "beta", and any functionality of the
codebase (such as the
[interpolation|https://commons.apache.org/proper/commons-math/commons-math4-legacy/apidocs/org/apache/commons/math4/legacy/analysis/interpolation/package-summary.html]
"legacy" package) is a candidate for re-implementation as a standalone
"module" (cf. other such
[modules|https://commons.apache.org/proper/commons-math/modules.html]).
It's an opportunity for algorithms' varying requirements to be satisfied in a
consistent and safe way.
Regarding the other comment on GH:
bq. The class already present in the javadoc for 4.0-beta1, but actually it's
still it's not in the codebase.
It was indeed a mistake, either in the generation of the web site, or perhaps
even in the source release (?). Sorry about that.
> Add clamped spline interpolation
> --------------------------------
>
> Key: MATH-1650
> URL: https://issues.apache.org/jira/browse/MATH-1650
> Project: Commons Math
> Issue Type: New Feature
> Affects Versions: 4.X
> Reporter: Michael Scholz
> Priority: Minor
> Labels: Polynomials, interpolation, spline
> Attachments: 2022-10-05_ClampedSplineInterpolator.patch
>
>
> We would like to contribute a new _clamped_ spline interpolation function in
> addition to the already available unclamped spline function. Our new
> {{ClampedSplineInterpolator}} is based on the same textbook as the original
> {{{}SplineInterpolator{}}}. The clamped spline offers additional
> parameterisation of starting and ending slopes (1st derivatives) as boundary
> conditions in order to provide more flexibility in spline creation.
> In this patch we follow the approach of subclassing the original
> {{SplineInterpolator}} and simply overloading it's {{interpolate()}} function
> by these two additional parameters. Is this an acceptable way or does the
> community recommend a different design approach?
> After clarifying the basic implementation approach we could also supply
> necessary tests etc. and finally contribute everything via ordinary GitHub
> pull request.
> Refer to our post on the dev mailing list:
> https://lists.apache.org/thread/34qnx4tgjbyv345lgmd57g0bnlnwdzc8
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
