ppkarwasz commented on PR #1327: URL: https://github.com/apache/commons-lang/pull/1327#issuecomment-2554050328
@garydgregory, > Another issue here is that for every single step in the `for` loop, the PR does a _sequential_ search in a collection. Is it worth doing a _binary_ search instead (at the cost for sorting the array)? Like this: Currently it is a lookup in a `Set` (not a generic collection): https://github.com/apache/commons-lang/blob/e0e3f0890c9164fcc9e76334aadd870dd4c8ef2a/src/main/java/org/apache/commons/lang3/StringUtils.java#L2877-L2887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
