mkomko commented on code in PR #354:
URL: https://github.com/apache/commons-email/pull/354#discussion_r2111321800
##########
commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/Email.java:
##########
@@ -1640,6 +1659,20 @@ public Email setStartTLSRequired(final boolean
startTlsRequired) {
return this;
}
+ /**
+ * Sets or disable OAuth2 authentication.
Review Comment:
```suggestion
* Sets or disables OAuth2 authentication.
```
##########
commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/Email.java:
##########
@@ -1639,6 +1658,20 @@ public Email setStartTLSRequired(final boolean
startTlsRequired) {
return this;
}
+ /**
+ * Sets or disable OAuth2 authentication.
Review Comment:
```suggestion
* Sets or disables OAuth2 authentication.
```
##########
commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/Email.java:
##########
@@ -822,6 +827,10 @@ public Session getMailSession() throws EmailException {
properties.setProperty(EmailConstants.MAIL_SMTP_AUTH, "true");
}
+ if(isOAuth2Required()) {
Review Comment:
```suggestion
if (isOAuth2Required()) {
```
##########
commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/Email.java:
##########
@@ -823,6 +828,10 @@ public Session getMailSession() throws EmailException {
properties.setProperty(EmailConstants.MAIL_SMTP_AUTH, "true");
}
+ if(isOAuth2Required()) {
Review Comment:
If we are being petty, there is a space missing 😄
```suggestion
if (isOAuth2Required()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
