garydgregory commented on PR #1418: URL: https://github.com/apache/commons-lang/pull/1418#issuecomment-3094676216
-1: This is the same kind of change you tried in your other 2 pull requests. This is noise at this point. Some of these changes are the same as in another open PR. I'll say it again: You need a unit test to prove that the changes in `main` fix anything. The test must fail when the changes to `main` are not applied. This doesn't appear to fix anything; it just copies and duplicates code. Follow https://github.com/apache/commons-lang/blob/master/.github/pull_request_template.md, which is normally in the description of a new PR. Don't delete templated text, add to it your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
