ppkarwasz commented on code in PR #633:
URL:
https://github.com/apache/commons-collections/pull/633#discussion_r2272170577
##########
src/test/java/org/apache/commons/collections4/SetUtilsTest.java:
##########
@@ -218,6 +223,31 @@ void testUnion() {
assertThrows(NullPointerException.class, () -> SetUtils.union(null,
setA));
}
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
+ void testReverseNestedUnionPerfomWell(final boolean mergeLeft) {
+ Set<Integer> set = SetUtils.union(setA, setB);
+ for (int i = 0; i < 40; i++) {
Review Comment:
_Nitpick_: I would even put `128` here. If the exponential growth were to be
reintroduced by mistake, future machines might still be able to handle 1
trillion ops/s, but with `2^128` we are future-proof.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
