ecki commented on code in PR #781:
URL: https://github.com/apache/commons-io/pull/781#discussion_r2330580155
##########
src/main/java/org/apache/commons/io/FileSystem.java:
##########
@@ -107,7 +107,7 @@ public enum FileSystem {
"LPT1", "LPT2", "LPT3", "LPT4", "LPT5", "LPT6", "LPT7",
"LPT8", "LPT9",
"LPT\u00b2", "LPT\u00b3", "LPT\u00b9", // Superscript 2 3
1 in that order
"NUL", "PRN"
- }, true, true, '\\', LengthUnit.CHARS);
+ }, true, true, '\\', NameLengthStrategy.UTF16_CHARS);
Review Comment:
I agree with your differentiation, I was not sure the strategy addresses all
of them (and I am not sure if the CHARS in the name is the right terminology.
but maybe its clearer than CODEPOINTS).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
