renoth commented on code in PR #429:
URL:
https://github.com/apache/commons-fileupload/pull/429#discussion_r2333827508
##########
commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/FileItemInputIteratorImpl.java:
##########
@@ -286,7 +286,12 @@ protected void init(final AbstractFileUpload<?, ?, ?>
fileUploadBase, final Requ
progressNotifier = new
MultipartInput.ProgressNotifier(fileUploadBase.getProgressListener(),
requestSize);
try {
- multiPartInput =
MultipartInput.builder().setInputStream(inputStream).setBoundary(multiPartBoundary).setProgressNotifier(progressNotifier).get();
+ multiPartInput = MultipartInput.builder()
+ .setInputStream(inputStream)
+ .setBoundary(multiPartBoundary)
+ .setProgressNotifier(progressNotifier)
+ .setPartHeaderSizeMax(fileUploadBase.getPartHeaderSizeMax())
Review Comment:
Shouldn't the partHeaderSizeMax be the Value configured in maxPartHeaderSize
of the Connectors? see
https://tomcat.apache.org/tomcat-10.1-doc/config/http.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]