ppkarwasz commented on PR #706: URL: https://github.com/apache/commons-compress/pull/706#issuecomment-3306903780
BTW: the tests were intentionally rewritten to use the new builder pattern rather than the legacy constructors. The idea was to hold our own code to the same standard that many of our users apply to theirs: some projects now **fail** the build if deprecated APIs are used. By doing this, we make sure every deprecation is **deliberate** and **considered**. However, personally, I wouldn’t deprecate any constructors in `1.29.0`. My preference would be to first announce the plan in the release notes, then introduce the deprecations in `1.30.0`. To smooth the migration, we could also add Error Prone’s `@InlineMe` annotations. These are already supported by tools like Refaster and OpenRewrite, so users would be able to automatically rewrite call sites away from deprecated methods. What do you think about this approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
