toxn commented on PR #396:
URL: https://github.com/apache/commons-cli/pull/396#issuecomment-3312601069

   I took the initiative to fix `TypeHandlerTest:testCreateDate` to ensure 
correct compilation.
   Problem was stemming from `Date::toString` outputting an english-locale date 
even when the system is in another locale.
   
   This could be a real bug if `TypeHandler::createDate` should only accept an 
english date (nothing specified in javadoc regarding locale).
   
   Maybe `Converter.DATE` could either enforce english locale, or try english 
locale upon failure with default locale.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to