garydgregory commented on code in PR #784:
URL: https://github.com/apache/commons-io/pull/784#discussion_r2366415478
##########
src/main/java/org/apache/commons/io/build/AbstractOrigin.java:
##########
@@ -137,6 +372,16 @@ public Writer getWriter(final Charset charset, final
OpenOption... options) thro
return new OutputStreamWriter(getOutputStream(options),
Charsets.toCharset(charset));
}
+ @Override
+ public ReadableByteChannel getReadableByteChannel(OpenOption...
options) throws IOException {
+ return getRandomAccessFile(options).getChannel();
Review Comment:
If `RandomAccessFile.getChannel()` always returns a `FileChannel` and
`FileChannel` implements
`SeekableByteChannel`, `GatheringByteChannel`, `ScatteringByteChannel`, why
not just have a `getFileChannel()`? I guess that depends on the typing of the
overriden method. Or maybe both of these should call a `getFileChannel()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
