ppkarwasz commented on PR #789: URL: https://github.com/apache/commons-io/pull/789#issuecomment-3346050838
Hi @garydgregory, > I added a resource management paragraph at the class level. I think the table does a really nice job of documenting the whole thing. I am not sure which “resource management paragraph” are you referring to. Is it the first paragraph? https://github.com/apache/commons-io/blob/2207f9a8043ea35d58186aacb79b2f2520372238/src/main/java/org/apache/commons/io/build/AbstractOrigin.java#L62-L64 I am not entirely sure that this conveys the entire semantics of `AbstractOrigin`, which is: - If the origin is a resource, getters will return a wrapped resource. - If the origin is not a resource, getters will return a new resource, that the caller must close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
