garydgregory commented on code in PR #790:
URL: https://github.com/apache/commons-io/pull/790#discussion_r2391090729
##########
src/main/java/org/apache/commons/io/input/ClosedReader.java:
##########
@@ -71,6 +71,10 @@ public void close() throws IOException {
*/
@Override
public int read(final char[] cbuf, final int off, final int len) {
+ IOUtils.checkFromIndexSize(cbuf, off, len);
Review Comment:
Hello @ppkarwasz
This is now in contradiction to the Javadoc for the class, the method, all
method parameters, and the return tag.
For each call to `checkFromIndexSize`, the Javadoc might need to be adjusted
or the behavior should remain the same, each use case must be reviewed 😞 Let's
start with this one. What to do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
