mkomko commented on PR #354: URL: https://github.com/apache/commons-email/pull/354#issuecomment-3355009577
Hi everyone, I just wanted to bring this PR back into focus, as it seems to be stuck. The functionality here is (IMHO) quite important for users, and leaving it unmerged might risk discouraging adoption or pushing people away who rely on this feature. From what I can see, the change is essentially just forwarding a parameter to Jakarta Mail. That’s a very low-risk adjustment, and while of course thorough tests are always valuable, in this specific case the cost–benefit trade-off of waiting for a full test suite may not justify the delay. I'm not sure @sgoeschl is prepared to invest this kind of time, since he is no longer really active. Would it be possible to merge this with at least a minimal test that checks whether the parameter has been set (or even with a clear TODO for additional tests), so that the community can start benefiting from it? Alternatively, maybe a committer or contributor closer to the project could help add the tests, if they are considered strictly necessary. This way the feature doesn’t stay blocked, users get what they need, and the code quality expectations of the project can still be met in a collaborative way. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
