[ 
https://issues.apache.org/jira/browse/LANG-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18029889#comment-18029889
 ] 

Gary D. Gregory commented on LANG-1790:
---------------------------------------

Hello [~smertk] 

Thank you for your request.

Feel free to create a PR on GitHub. Use the Builder to add features, not a new 
constructor.

 

> Fairness setting in TimedSemaphore
> ----------------------------------
>
>                 Key: LANG-1790
>                 URL: https://issues.apache.org/jira/browse/LANG-1790
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.concurrent.*
>            Reporter: Mert Kirpici
>            Priority: Major
>
> The {{TimedSemaphore}} structure javadocs do not mention anything about 
> fairness.
> If this is something that the current implementation does not provide, the 
> {{TimedSemaphore}} structure could benefit from a _fairness_ setting like the 
> {{java.util.concurrent.Semaphore}} does, which will queue up the threads that 
> are blocked by the {{.acquire()}} call and when the timer expires, they will 
> be permitted access to the shared resource in a FIFO fashion.
> A possible implementation could be like this in the constructor:
> {{TimedSemaphore(long timePeriod, TimeUnit timeUnit, int limit, boolean 
> fair)}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to