ppkarwasz commented on code in PR #1495:
URL: https://github.com/apache/commons-lang/pull/1495#discussion_r2542027861
##########
src/test/java/org/apache/commons/lang3/ClassUtilsTest.java:
##########
@@ -1229,6 +1231,7 @@ void testGetClassByNormalNameArrays() throws
ClassNotFoundException {
assertEquals(java.util.Map.Entry[].class,
ClassUtils.getClass("java.util.Map$Entry[]"));
assertEquals(java.util.Map.Entry[].class,
ClassUtils.getClass("[Ljava.util.Map.Entry;"));
assertEquals(java.util.Map.Entry[].class,
ClassUtils.getClass("[Ljava.util.Map$Entry;"));
+ assertEquals(java.util.Map.Entry[][].class,
ClassUtils.getClass("[[Ljava.util.Map$Entry;"));
Review Comment:
Sure, reorganizing the test cases can be done separately.
I brought up these specific tests (especially the last one,
`[Ljava.util.Map.Entry;`) because I tend to treat them as an explicit list of
**required** behavior for the method, rather than incidental behavior. The
tests included in a release strongly influence the constraints and direction of
future changes, so I review them carefully as part of the design.
I'll propose some changes to the tests in a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
