IcoreE opened a new pull request, #1501: URL: https://github.com/apache/commons-lang/pull/1501
https://issues.apache.org/jira/browse/LANG-1793 The Javadoc of the isAsciiAlphanumeric method in CharUtils contains an incorrect description. The first sentence currently states:“Tests whether the character is ASCII 7 bit numeric.” However, the actual implementation checks whether the character is alphanumeric, meaning it returns true for both: alphabetic characters (A–Z, a–z), andnumeric characters (0–9). This mismatch between the Javadoc and the method behavior is misleading and may cause confusion for API users. The documentation should be updated to reflect that the method checks for ASCII alphanumeric characters, not numeric characters only. Before you push a pull request, review this list: - [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. - [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
