garydgregory commented on PR #1504: URL: https://github.com/apache/commons-lang/pull/1504#issuecomment-3583057223
-1 for a few reasons: - Editing a license header is not acceptable. - Deleting whole tests is not acceptable; this hints that the PR breaks existing functionality. Also: - New code is not documented in Javadoc to explain the behavior changes. - Don't make formatting changes; it makes the PR noisier than it has to be. - This PR description doesn't describe how the solution it proposes is implemented - Too many empty lines for no reason, it's sloppy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
