sebbASF commented on code in PR #304:
URL: https://github.com/apache/commons-daemon/pull/304#discussion_r2667661414
##########
src/native/unix/native/jsvc-unix.c:
##########
@@ -673,7 +672,7 @@ static int get_pidf(arg_data *args, bool quiet)
int i;
char buff[80];
- fd = open(args->pidf, O_RDONLY, 0);
+ fd = open(args->pidf, O_RDWR, 0);
Review Comment:
Agreed, but I think the reason for allowing WRite should be documented in
the code.
Possibly consider a private function to obtain the fd; this can then be
fully documented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
