rajucomp commented on PR #1553: URL: https://github.com/apache/commons-lang/pull/1553#issuecomment-3720221471
Hi @garydgregory . Thanks for the fix. I would like some guidance on how to raise PR's for issues and fixes. 1) Looking at the comments on the various issues, I deduced that in order to fix an issue, first a PR with a failing test should be raised to confirm the issue. 2) Once the maintainers i.e. you acknowledge the bug, then we push the fix on the same PR. I am not sure if I am following the right pattern here. Could you please provide some tips here ? Additionally, it would be better if we provide the chance to review the fix before the changes are merged into the master branch. Ab additional set of eyes don't hurt and makes the fix error-free. There is a small issue that I found in your fix. I have commited the fix in this PR. Could you review the changes and let me know if all looks good ? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
