jhaShalu commented on PR #423:
URL: https://github.com/apache/commons-codec/pull/423#issuecomment-3890807670
> Hello @Shalujha0907
>
> Thank you for the PR!
>
> I see this PR changes the expectation for `CHARACTER` from `KRKT` to
`XRKT`, but isn't the correct value `XRKTR`?
Hello @garydgregory
Thanks for the review and for calling this out.
XRKTR is the full phonetic sequence, but Metaphone in Commons Codec uses a
default maxCodeLen of 4, so the returned value is truncated to XRKT.
That’s why this test expects XRKT (and not XRKTR) unless
[setMaxCodeLen(...)](app://-/index.html#) is increased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
