Copilot commented on code in PR #398: URL: https://github.com/apache/commons-jexl/pull/398#discussion_r2807907948
########## src/main/java/org/apache/commons/jexl3/internal/TemplateInfo.java: ########## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.commons.jexl3.internal; + +import java.util.Set; + +import org.apache.commons.jexl3.JexlInfo; + +/** + * A JexlInfo that also carries the set of tokens that should be ignored during parsing, + * most notably the prefix for templates. + */ +public class TemplateInfo extends JexlInfo { + private final Set<String> ignoredTokens; + + public TemplateInfo(JexlInfo info, Set<String> ignoredTokens) { Review Comment: Constructor parameters should be declared as `final` to be consistent with the codebase convention. For example, JexlInfo constructor at line 120 uses `final String source`, and Scope constructor at internal/Scope.java:95 uses `final Scope scope`. The parameters `info` and `ignoredTokens` should be declared as `final JexlInfo info` and `final Set<String> ignoredTokens`. ```suggestion public TemplateInfo(final JexlInfo info, final Set<String> ignoredTokens) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
