atakavci opened a new pull request, #454: URL: https://github.com/apache/commons-pool/pull/454
## Summary A behavioral regression was introduced in [commons-pool 2.13.0](https://commons.apache.org/proper/commons-pool/changes.html#a2.13.0) as part of the fix for [POOL-424](https://issues.apache.org/jira/browse/POOL-424), which ensures that `invalidateObject()` replaces the destroyed instance by internally calling `addObject()`. This PR replaces the `addObject()` replenishment call in `GenericObjectPool.invalidateObject` with a strategy consistent with how `GenericKeyedObjectPool.invalidateObject` already handles this via `reuseCapacity()`. ```java // before addObject(); // after if (!isClosed() && idleObjects.hasTakeWaiters()) { try { addIdleObject(create(Duration.ZERO)); } catch (final Exception e) { swallowException(e); } } ``` ## Rationale `addObject()` brings potentially unexpected behaviour other than propogating factory fails to call site: it blocks up to `maxWait`, silently no-ops when `numIdle >= maxIdle`, creates unconditionally without checking for waiters, and propagates factory exceptions — which can cause `invalidateObject()` to throw after the invalidation has already succeeded. The new approach is waiter-aware (`hasTakeWaiters`), non-blocking (`Duration.ZERO`), bypasses the `maxIdle` inventory gate, and swallows factory exceptions via `swallowException`. Pool state is checked upfront with `!isClosed()`; lifecycle management beyond that remains the responsibility of `close()`. ## Files changed - `src/main/java/org/apache/commons/pool2/impl/GenericObjectPool.java` _________________________________________________________________________ <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull request, review this list: - [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
