ilang commented on PR #761: URL: https://github.com/apache/commons-vfs/pull/761#issuecomment-4224557943
You're right about the SFTP test — I've removed it. The SFTP code change (`resolveFileInternal` in `doListChildrenResolved()` + `injectType(null)` after `setStat()`) applies the same `resolveFileInternal` principle consistently, but has no server-side observable difference. SFTP's `doListChildrenResolved()` pushes metadata to each child via `setStat()` immediately after resolution, so the ON_RESOLVE refresh is redundant client-side work — clearing `attrs` that is immediately repopulated. Unlike FTP, where the cascade causes real network LIST commands, the SFTP optimization is purely client-side and cannot be distinguished by a server-side test. If you prefer, I can drop the SFTP changes from this PR and submit them separately, keeping this PR focused on the FTP-observable fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
