garydgregory commented on PR #1628:
URL: https://github.com/apache/commons-lang/pull/1628#issuecomment-4322279728
@ax1nch
This test doesn't compare anything useful. You need to compare the old code
vs. the new code, so:
```java
!f.isInfinite() && !(f.floatValue() == 0.0F && !isZero(mant, dec)) &&
f.toString().equals(d.toString())
```
versus
```java
!f.isInfinite() && !(f.floatValue() == 0.0F && !isZero(mant, dec))
&& ((double) d.floatValue() == d.doubleValue() ||
f.toString().equals(d.toString()))
```
or the whole of the old method vs. the whole of the new method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
